Re: [Libvir] [PATCH] Refactor xend_internal.c block device detection

Daniel P. Berrange wrote: >On Tue, Oct 16, 2007 at 02:13:04PM +0100, Richard W.M. Jones wrote: >>This patch is a little bit esoteric, but I need it for something I'm >>working on at the moment. >> >>At the moment the code in xend_internal.c: xend_parse_sexp_desc parses >>the domain sexpr directly into XML. This makes it rather hard to just >>get a list of block devices without repeating the same code. So here >>I've factored out the common code for parsing block devices into a >>separate function and callback. > >I agree that its good to separate this code out, however, I'd split it >slightly differently. Instead of a function to parse all block devices >and a callback to receive each one, I'd have the new function just be >responsible for parsing a single block device. Keep iteration over block >devices in the caller & avoid the callback. This is more in keeping with >the style of the other functions for parsing XML & related domain info >formats I'm not sure I understand. Do you mean the function would parse a block device and return a structure?