Re: [libvirt] [PATCH] storage: Fix printing/casting of uid_t/gid_t

On 12/05/2014 04:16 AM, Peter Krempa wrote: > Other parts of libvirt use "%u" for formatting uid/gid and typecast to > unsigned int. Storage driver used the signed variant. > --- > src/storage/storage_driver.c | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c > index 7f4de19..24b54f4 100644 > --- a/src/storage/storage_driver.c > +++ b/src/storage/storage_driver.c > @@ -2797,7 +2797,8 @@ virStorageFileChown(virStorageSourcePtr src, > return -2; > } > > - VIR_DEBUG("chown of storage file %p to %d:%d", src, uid, gid); > + VIR_DEBUG("chown of storage file %p to %u:%u", > + src, (unsigned int)uid, (unsigned int)gid); > > return src->drv->backend->storageFileChown(src, uid, gid); > } > @@ -2819,9 +2820,9 @@ virStorageFileGetMetadataRecurse(virStorageSourcePtr src, > virStorageSourcePtr backingStore = NULL; > int backingFormat; > > - VIR_DEBUG("path=%s format=%d uid=%d gid=%d probe=%d", > + VIR_DEBUG("path=%s format=%d uid=%d gid=%u probe=%u", Need %u for uid and %d for probe (that's a boolean)

ACK w/ that

John