Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect
On 03/27/13 16:26, Viktor Mihajlovski wrote:
On 03/27/2013 04:13 PM, Peter Krempa wrote:
>
> I've re-run the test suite and I'm not getting any errors. I have the
> current upstream (including your 2/3 patch from v1) and these four on
> top.
>
> What tests are failing for you?
>
> Peter
>
After taking out 1/3 I don't get the errors, which is logical,
as the refcount isn't incremented in the register callback.
It seems that there are quite a lot situations where virsh
exits without unregistering the callback.
Please apply 1/3 (which is actually the essential patch
of the series) to see it happen.
My tree actually contains 1/3 from your v1 series and I also reposted it
in my v2 and I don't seem to be getting errors when I have the 4 (5 with
the one pushed upstream) patches applied.
Peter