Re: [libvirt][PATCH v6 6/6] add qemu capabilities version 5.2.0
On Mon, Aug 23, 2021 at 07:59:56 +0000, Huang, Haibin wrote:
> -----Original Message-----
> From: Peter Krempa <pkrempa(a)redhat.com>
> Sent: Friday, August 20, 2021 4:10 PM
> To: Huang, Haibin <haibin.huang(a)intel.com>
> Cc: libvir-list(a)redhat.com; Ding, Jian-feng <jian-feng.ding(a)intel.com>; Yang,
> Lin A <lin.a.yang(a)intel.com>; Lu, Lianhao <lianhao.lu(a)intel.com>;
> pbonzini(a)redhat.com
> Subject: Re: [libvirt][PATCH v6 6/6] add qemu capabilities version 5.2.0
>
> On Fri, Aug 20, 2021 at 14:15:06 +0800, Haibin Huang wrote:
> > Signed-off-by: Haibin Huang <haibin.huang(a)intel.com>
> > ---
> > docs/schemas/domaincaps.rng | 4 +-
> > .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 207 +
> > .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 201 +
> > tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 207 +
> > .../caps_5.2.0.x86_64.replies | 29649 ++++++++++++++++
> > .../caps_5.2.0.x86_64.xml | 3189 ++
> > 6 files changed, 33455 insertions(+), 2 deletions(-) create mode
> > 100644 tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml
> > create mode 100644 tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml
> > create mode 100644 tests/domaincapsdata/qemu_5.2.0.x86_64.xml
> > create mode 100644
> > tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies
> > create mode 100644 tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
>
> This patch doesn't seem to be agains current upstream master. We already do
> have caps dump for qemu-5.2
[Haibin] yes, the SGX qemu patch will be merge in qemu-6.2, I will delete the unit test
patch
I plan to write the unit test after qemu-6.2, is it ok?
I meant that this particular patch is not based on top of upstream
libvirtd. I've just judged it by the fact that you are adding a file
that is already present in the repository for almost a year.
In fact this whole series doesn't apply on master.