Re: [libvirt] [PATCH 06/17] nwfilter: Add configFile into virNWFilterObj
On 07/13/2017 10:41 AM, Michal Privoznik wrote:
On 06/02/2017 12:25 PM, John Ferlan wrote:
> When creating an object, save the configFile name in the object rather
> than needing to build it up each time for the SaveConfig. This involves
> adding a @configDir parameter to virNWFilterObjListAssignDef and removing
> the @configDir from virNWFilterObjSaveConfig.
Why? This keeps the path in memory for the whole life time of the object
even though it's needed just occasionally - at the beginning and
probably at the end.
I'm going to drop this one.
John
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> src/conf/virnwfilterobj.c | 38 ++++++++++++++++++++------------------
> src/conf/virnwfilterobj.h | 6 +++---
> src/nwfilter/nwfilter_driver.c | 5 +++--
> 3 files changed, 26 insertions(+), 23 deletions(-)
Michal