Re: [Libvir] Patch: Fix documentation and code of virGetDomain function
On Wed, Feb 28, 2007 at 04:24:10PM +0000, Richard W.M. Jones wrote:
It turns out that you _can't_ pass name=NULL to virGetDomain, despite
what the docs say.
The goal was to allow searching by name or uuid (or both), that was the
principle of the API, unfortunately UUID search was not implemented. The right
fix is to add the lookup by UUID, as the TODO below indicated
/* TODO search by UUID first as they are better differenciators */
changing the API instead is not the right approach. In a nutshell I
disagree with the patch, it does do the right thing.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/