On Thu, Dec 08, 2022 at 14:30:44 +0100, Pavel Hrdina wrote:
External snapshots will use this to synchronize qemu block jobs.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/qemu/qemu_block.c | 7 ++++++-
src/qemu/qemu_block.h | 1 +
src/qemu/qemu_driver.c | 3 ++-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 5600abf6aa..2abddf904f 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -3198,6 +3198,10 @@ qemuBlockExportAddNBD(virDomainObj *vm,
}
+/* The autofinalize argument controls if the qemu block job will be automatically
+ * finalized. This is used when deleting external snapshots where we need to
+ * disable automatic finalization for some use-case. The default value passed
+ * to this argument should be VIR_TRISTATE_BOOL_YES.*/
In reply to previous patch I asked to do our usual function parameter
description already for the 'asyncJob' so this will then be added to
that comment.
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>