Re: [libvirt] [PATCH v5 03/13] conf: Introduce a new PCI address extension flag

On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote: [...] > @@ -164,6 +164,7 @@ struct _virDomainDeviceInfo { > * assignment, never saved and never reported. > */ > int pciConnectFlags; /* enum virDomainPCIConnectFlags */ > + int pciAddressExtFlags; /* enum virDomainPCIAddressExtensionFlags */ There's a comment right above this that explains how pciConnectFlags is only used during address assignment: you should amend it to mention pciAddressExtFlags too. Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt;