Re: [libvirt] [PATCH 13/14] Avoid unsafe use of /proc/$PID/root in LXC chardev hostdev hotplug

Rewrite lxcDomainAttachDeviceHostdevMisceLive function

to use the virProcessRunInMountNamespace helper. This avoids risk of a malicious guest replacing /dev with a absolute symlink, tricking the driver into changing the host OS filesystem. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- src/lxc/lxc_driver.c | 66 ++++++++++++++-------------------------------------- 1 file changed, 18 insertions(+), 48 deletions(-)

+ if (virCgroupAllowDevicePath(priv->cgroup, + def->source.caps.u.misc.chardev, + VIR_CGROUP_DEVICE_RWM) != 0) {

+ def->source.caps.u.misc.chardev) < 0) { + if (virCgroupDenyDevicePath(priv->cgroup, + def->source.caps.u.misc.chardev, + VIR_CGROUP_DEVICE_RWM) != 0) + VIR_WARN("cannot deny device %s for domain %s", + def->source.caps.u.storage.block, vm->def->name); goto cleanup;