Re: [libvirt] [PATCHv2 00/14] vcpu - distinguish maximum from current

Version 1 had ACKs on most of the patches, but raised several points (not the least of which was a lack of testing). I've now done more testing on xen than on qemu, so there may still be some qemu quirks. Version 2 of the patch series; this addresses most of the points from v1 (http://thread.gmane.org/gmane.comp.emulators.libvirt/28520). I'm thinking that it is possible to backport _just_ patches 1 (add current attribute), 7 (add maxvcpus to xml), and 12 (xen xm and sexpr support) to make RHEL 5 xen support the distinction at the XML layer without the expense of an API addition (that is, the existing dumpxml API is sufficient to expose the core change in this patch series, and the remaining patches in the series are just sugar to make it easier). However, I still have to test that theory. I also have one patch to write - namely, making xen support virDomainSetVcpusFlags. But I'd rather get the review going on the rest of these patches, since it's now the last remaining 0.8.5 candidate feature. Summary of changes in v2 (more details in each patch): - rename flags from _ACTIVE/_PERSISTENT to _LIVE/_CONFIG for consistency with granularity of DeviceAttach - first cut at xen implementation, dealing with fact that vcpu_avail in xen world is a bitmask rather than a count - factor common flag checks out of drivers - add 'virsh maxvcpus' - add support for test:///default I'll send an interdiff for how this series differs from v1, if that helps in the review.