Re: [libvirt] [PATCH 17/30] remote: Remove virConnectPtr from error/errorf
On 04/12/2010 09:03 AM, Dave Allan wrote:
>>> + remoteError(VIR_ERR_INVALID_ARG,
"%s",
>>> + _("transport methods unix, ssh and ext are not
supported "
>>> + "under Windows"));
>>
>> I see why you broke this line, to fit 80 columns, but that can impact
>> grep-ability of the original message. Is there any policy on this?
>>
>
> I'm not aware of any policy for this, but we have many error messages
> split into multiple lines already.
I agree that it impacts grep-ability in the code, but very long lines
impact the readability of the code, so in general, I'm in favor of
splitting lines.
Good to know; thanks for the answers.
Meanwhile, I've seen this paradigm in some other projects (glibc,
coreutils, ...), to at least reduce the number of splits due to long
messages:
remoteError(VIR_ERR_INVALID_ARG, "%s", _("\
transport methods unix, ssh and ext are not supported under Windows"));
By using the \-newline combo, and starting the message at column 1,
you've bought yourself quite a bit of line length, without any change to
the resulting message either on screen or in the .pot file.
But I'm not bothered enough by the current situation to spend any of my
time reformatting existing messages to a new format, so for now, I'm
happy leaving things as they are.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 323 bytes)