Re: [libvirt PATCH v2 4/6] ci: Introduce a util module
On Tue, 2021-03-16 at 18:32 +0100, Erik Skultety wrote:
+++ b/ci/util.py
+def get_registry_images(uri: str) -> Dict[str, str]:
On closer inspection, the return type is not correct: we return a
list of JSON objects, not a mapping from strings to strings.
I don't know how to express that in terms of Python types
(List[Dict[str, Any]]?), and I'm concerned by the fact that changing
the return type to something obviously wrong like "int" results in
zero observable changes.
How are type hints enforced? Do we need to turn that on somehow?
--
Andrea Bolognani / Red Hat / Virtualization