Re: [libvirt] [PATCH] Close logfile fd after spawning qemu
On Thu, Sep 10, 2009 at 6:04 PM, Daniel Veillard<veillard(a)redhat.com> wrote:
Hum, it's not quite simple. It's passed down to __virExec()
where it is provided as the stdout/stderr to use, it's not closed
there on the parent though. I guess it's safe to close it at that
point at the end of qemudStartVMDaemon() since only the child can
use it (up to the exec because it is been close on exec'ed).
Hmm, I'm not sure the effect to the child though, it sounds safer.
ozaki-r
So looks fine to me but I would appreciate a second opinion :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/