Re: [libvirt] [PATCH 0/4] more phyp refactoring
On 04/14/2011 09:51 AM, Matthias Bolte wrote:
>> src/phyp/phyp_driver.c | 1128
+++++++-----------------------------------------
>> 1 files changed, 163 insertions(+), 965 deletions(-)
>
> Serves me right for thinking Matthias' cleanups had already been
> applied. Now I get to rebase, with lots of conflicts :)
Sorry for that :(
No problem. The fault is mostly mine for seeing your series and its
review, and assuming it was in without verifying it myself. :)
I'm currently quite busy with my studies and can only spent some time
on weekends for libvirt development to get some distraction. This
results in longer delays between libvirt related things I do. Today, I
successfully took an exam and am relaxing with libvirt stuff right
now.
You probably want to post a rebased v2 before I review your phyp
patches, don't you?
Yep, and v2 will be larger because I've found more leaks in the
meantime. Plus, your 2/5 missed cleaning up the error paths for all the
new interface functions that I just pushed in between when you submitted
your patches for review vs. actually pushing them, so I'm fixing those
to be consistent, as well.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)