Re: [libvirt] [PATCH v3 4/5] qemu: Use VIR_ERR_DEVICE_MISSING for various DetachDeviceConfig messages
Let's alter the commit message to be more similar to patch 3/5, e.g.:
qemu: Use VIR_ERR_DEVICE_MISSING for various coldplug messages
On 01/22/2018 11:24 PM, Chen Hanxiao wrote:
From: Chen Hanxiao <chenhanxiao(a)gmail.com>
Modify OPERATION_FAILED error codes to use DEVICE_MISSING instead.
Changing this to:
Use the DEVICE_MISSING error code when helpers fail to find
the requested device. This makes it easier for consumers to
key off the error code rather than the error message.
...
again no need to post an update, I can make the adjustment...
Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com>
---
src/qemu/qemu_driver.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index a203c9297..10eebd61c 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8172,7 +8172,7 @@ qemuDomainDetachDeviceConfig(virDomainDefPtr vmdef,
case VIR_DOMAIN_DEVICE_HOSTDEV: {
Any specific reason you didn't alter the VIR_DOMAIN_DEVICE_DISK error
code as well? I can do that for you before pushing.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
[...]