Re: [Libvir] [PATCH] Fix cdrom connect/disconnect for qemu
On Wed, Mar 12, 2008 at 12:57:59PM -0400, Cole Robinson wrote:
The attached patch fixes cdrom changing for a live qemu guest. There
were a few issues preventing it from working:
1) It didn't anticipate no <source> block in the xml.
2) No support for ejecting the media
3) Small bug which prevented the running guest xml from being updated.
I've tested this via virt-manager, and now qemu and xen seem
to have parity wrt cdrom connect/disconnect.
Looks good to me, applied and commited,
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/