Re: [libvirt] [libvirt-glib 01/37] Add gvir_config_object_new_child helper

Hey, On Fri, Nov 11, 2011 at 03:28:34PM +0100, Marc-André Lureau wrote: > The functions declaration should be put in -private.h . Marking > definition G_GNUC_INTERNAL would also make it more obvious. > > It would also less confuse gir-scanner which doesn't know about libxml types. At this point, I'm undecided whether these functions should be private or not. Having some way to directly manipulate the XML data can be useful when you want to generate some config data not yet handled by libvirt-gconfig, but on the other hand, it makes it really easy to shoot yourself in the foot. I'm fine with marking them private for now.