Re: [libvirt] [PATCH 11/13] tests: Add new tests for zPCI

On Thu, May 24, 2018 at 02:24:36PM +0200, Xiao Feng Ren wrote: > From: Yi Min Zhao <zyimin(a)linux.ibm.com&gt; > > This patch adds new test cases for zPCI when 'uid' and 'fid' > are defined with different conditions in XML. > > Signed-off-by: Yi Min Zhao <zyimin(a)linux.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > Reviewed-by: Bjoern Walk <bwalk(a)linux.ibm.com&gt; > Reviewed-by: Stefan Zimmermann <stzi(a)linux.vnet.ibm.com&gt; > --- > tests/qemuxml2argvdata/disk-virtio-s390-zpci.args  | 27 +++++++++ > tests/qemuxml2argvdata/disk-virtio-s390-zpci.xml   | 17 ++++++ > .../hostdev-vfio-zpci-autogenerate.args            | 24 ++++++++ > .../hostdev-vfio-zpci-autogenerate.xml             | 18 ++++++ > .../hostdev-vfio-zpci-boundaries.args              | 27 +++++++++ > .../hostdev-vfio-zpci-boundaries.xml               | 26 +++++++++ > .../hostdev-vfio-zpci-multidomain-many.args        | 38 ++++++++++++ > .../hostdev-vfio-zpci-multidomain-many.xml         | 67 > ++++++++++++++++++++++ > tests/qemuxml2argvdata/hostdev-vfio-zpci.args      | 24 ++++++++ > tests/qemuxml2argvdata/hostdev-vfio-zpci.xml       | 19 ++++++ > tests/qemuxml2argvtest.c                           | 21 +++++++ These should be squashed into the first commit that formats the command line > tests/qemuxml2xmloutdata/disk-virtio-s390-zpci.xml | 29 ++++++++++ > tests/qemuxml2xmloutdata/hostdev-vfio-zpci.xml     | 30 ++++++++++ > tests/qemuxml2xmltest.c                            |  3 + And these should be introduced along with the XML parser/formatter. That way the tests demonstrate if the subsequent code changes change the tests as well or not. Jano

> 14 files changed, 370 insertions(+) > create mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.args > create mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.xml > create mode 100644 > tests/qemuxml2argvdata/hostdev-vfio-zpci-autogenerate.args > create mode 100644 > tests/qemuxml2argvdata/hostdev-vfio-zpci-autogenerate.xml > create mode 100644 > tests/qemuxml2argvdata/hostdev-vfio-zpci-boundaries.args > create mode 100644 > tests/qemuxml2argvdata/hostdev-vfio-zpci-boundaries.xml > create mode 100644 > tests/qemuxml2argvdata/hostdev-vfio-zpci-multidomain-many.args > create mode 100644 > tests/qemuxml2argvdata/hostdev-vfio-zpci-multidomain-many.xml > create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-zpci.args > create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-zpci.xml > create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-s390-zpci.xml > create mode 100644 tests/qemuxml2xmloutdata/hostdev-vfio-zpci.xml