Re: [libvirt] [PATCH 04/14] Centralize error reporting for URI parsing/formatting problems

On 2012年03月21日 01:33, Daniel P. Berrange wrote: >From: "Daniel P. Berrange"<berrange(a)redhat.com> >@@ -70,8 +84,7 @@ virURIFormat(virURIPtr uri) > char *ret; > > /* First check: does it make sense to do anything */ >- if (uri != NULL&& >- uri->server != NULL&& >+ if (uri->server != NULL&& > strchr(uri->server, ':') != NULL) { > > backupserver = uri->server; >@@ -82,7 +95,12 @@ virURIFormat(virURIPtr uri) > } > > ret = (char *) xmlSaveUri(uri); >+ if (!ret) { >+ virReportOOMError(); >+ goto cleanup; >+ } > >+cleanup: The cleanup label doesn't make any sense. Or it's for follow up pacthes use? but it should be together with the follow up patch if so.