Re: [libvirt] [qemu RFC v2] qapi: add "firmware.json"
On Wed, Apr 18, 2018 at 01:48:10PM +0200, Laszlo Ersek wrote:
On 04/18/18 11:04, Gerd Hoffmann wrote:
>> This surfaced in the RFCv1 discussion, but Daniel suggested ignoring
>> version numbers:
>>
>> http://mid.mail-archive.com/20180410093412.GI5155@redhat.com
>>
>> On 04/10/18 11:34, Daniel P. Berrangé wrote:
>>> IMHO it would be valid to just keep life simple and only record the
>>> base machine type name that can use the firmware ie "pc",
"q35", and
>>> ignore the fact that in some cases the firmware might require a
>>> specific version of the machine type.
>
> IIRC this bit referes to the fact that SMM requires qemu >= 2.x (don't
> remember which x) to work. So smm-enabled edk2 would just say
> "pc-q35-*" instead of trying to specifying a version range somehow.
OK. I'm fine either way; Dan, can you please confirm you are OK with the
suggested wildcard format? (I.e., we still shouldn't include actual
version numbers in the supported machtypes list, but we should be more
specific than just "pc" and "q35" -- if the machine type is
versioned,
use an asterisk for covering the version number.)
My suggestion to use a bare "pc" is effectively doing globbing
anyway, just that we've left off the "*". Gerd is right that it
is probably better to be explicit and include the wildcard.
So now the question is should this string be declared to be
glob format, or regex format. Regex is more flexible, but
regex syntax is ill-defined because every regex engine is
slightly different.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|