Re: [libvirt] [PATCH v3 1/5] virsh: improve blockcopy UI

On 06/11/14 18:27, Eric Blake wrote: > Peter's review of my addition of active block commit pointed out > some issues that I had copied from block copy. It makes sense to > allow the shorter command-line of 'blockcopy $dom $disk --pivot' > without having to explicitly specify --wait. And my use of > embedded ?: ternaries bordered on unreadable. >

> @@ -1808,10 +1808,10 @@ cmdBlockCopy(vshControl *ctl, const vshCmd *cmd) > { > virDomainPtr dom = NULL; > bool ret = false; > - bool blocking = vshCommandOptBool(cmd, "wait"); > bool verbose = vshCommandOptBool(cmd, "verbose"); > bool pivot = vshCommandOptBool(cmd, "pivot"); > bool finish = vshCommandOptBool(cmd, "finish"); > + bool blocking = vshCommandOptBool(cmd, "wait"); Spurious line move?

> int timeout = 0; > struct sigaction sig_action; > struct sigaction old_sig_action; ACK,