On Tue, Jul 29, 2014 at 10:05:55PM -0600, Eric Blake wrote:
v5 was here, and got tentative ACKs:
https://www.redhat.com/archives/libvir-list/2014-July/msg01414.html
the only change is some reordering of logic in patch 2/2 (the former
4/4) to make sure that even for a super-fast commit where the event
d occurs before the API call regains the lock that the event is correct.
I'm still unsure whether to count this as a bug fix to a partial
new feature and include it in 1.2.7, or defer it to 1.2.8. If we
want it in this release, then getting it in before rc2 would be
the nicest.
I just tested the same scenario[1] I tried in v3 w/ libvirt git+v6 and
current QEMU git (d24e780427a08ea3b1b01e5058f1db37ec9a82ac). Works fine
here.
FWIW: Tested-by: Kashyap Chamarthy<kchamart(a)redhat.com>
[1]
http://www.redhat.com/archives/libvir-list/2014-June/msg01083.html
Also at:
http://repo.or.cz/w/libvirt/ericb.git/shortlog/refs/heads/gluster
or git checkout git://repo.or.cz/libvirt/ericb.git gluster
Eric Blake (2):
blockcommit: track job type in xml
blockcommit: turn on active commit
docs/formatdomain.html.in | 15 ++++---
docs/schemas/domaincommon.rng | 13 ++++++
src/conf/domain_conf.c | 33 ++++++++++++++-
src/conf/domain_conf.h | 1 +
src/qemu/qemu_driver.c | 48 +++++++++++++++++++---
src/qemu/qemu_process.c | 39 +++++++++++++++++-
.../qemuxml2argv-disk-active-commit.xml | 37 +++++++++++++++++
.../qemuxml2argvdata/qemuxml2argv-disk-mirror.xml | 6 +--
.../qemuxml2xmlout-disk-mirror-old.xml | 4 +-
tests/qemuxml2xmltest.c | 1 +
10 files changed, 179 insertions(+), 18 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-active-commit.xml
--
1.9.3
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
/kashyap