Re: [libvirt] [PATCH RFC] blockdev: copy legacy and common opts to qemu_drive_opts

Hi Kevin, On Mon, Nov 04, 2013 at 12:27:10PM +0100, Kevin Wolf wrote: It's to access the local QemuOptsLists of drive_init() and blockdev_init() for option="drive". I saw there are two repeat items ("copy-on-read", "read-only") I will merge the two desc lists together, remove the repeat items, and output once. Attached my draft patch, I can use it to compile qemu binary, but touched following error, any note? ------------------------ [amos@amosk qemu]$ make CC util/qemu-config.o AR libqemuutil.a LINK qemu-ga LINK qemu-nbd LINK qemu-img LINK qemu-io libqemuutil.a(qemu-config.o): In function `qmp_query_command_line_options': /home/devel/qemu/util/qemu-config.c:141: undefined reference to `qemu_legacy_drive_opts' /home/devel/qemu/util/qemu-config.c:142: undefined reference to `qemu_common_drive_opts' /home/devel/qemu/util/qemu-config.c:144: undefined reference to `qemu_drive_opts' collect2: error: ld returned 1 exit status make: *** [qemu-nbd] Error 1 make: *** Waiting for unfinished jobs.... libqemuutil.a(qemu-config.o): In function `qmp_query_command_line_options': /home/devel/qemu/util/qemu-config.c:141: undefined reference to `qemu_legacy_drive_opts' /home/devel/qemu/util/qemu-config.c:142: undefined reference to `qemu_common_drive_opts' /home/devel/qemu/util/qemu-config.c:144: undefined reference to `qemu_drive_opts' collect2: error: ld returned 1 exit status make: *** [qemu-img] Error 1 libqemuutil.a(qemu-config.o): In function `qmp_query_command_line_options': /home/devel/qemu/util/qemu-config.c:141: undefined reference to `qemu_legacy_drive_opts' /home/devel/qemu/util/qemu-config.c:142: undefined reference to `qemu_common_drive_opts' /home/devel/qemu/util/qemu-config.c:144: undefined reference to `qemu_drive_opts' collect2: error: ld returned 1 exit status make: *** [qemu-io] Error 1 LINK x86_64-softmmu/qemu-system-x86_64 -- Amos.