On 01/31/2013 07:42 AM, Corey Bryant wrote:
>
> ...this code is what checks for 1.3. In 1.2, the qemuMonitorAddFd()
> call fails with an error, so we clear the bit back out. Only 1.3 allows
> libvirt to specify its own set number, because that was one of the
> changes qemu had to make in order to add the -add-fd command-line option.
>
This approach looks fine for verifying the availability of 1.3 support
(assuming no fd sets were introduced prior to this point).
This particular check is done during our initial probe (basically,
inside something resembling 'qemu -M none -nodefaults -nographic -qmp
/path/to/socket'), and there are indeed no other fd sets in use. I've
gone ahead and pushed these two patches.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org