Re: [libvirt] [PATCH] qemu: add host per cpu info to all domain stats
On Wed, Feb 01, 2017 at 09:47:20 +0300, Nikolay Shirokovskiy wrote:
Info provided in virDomainGetCPUStats is now missed in all
domain stats. This patch removes this discrepancy.
Output example:
cpu.count=2
cpu.0.time=536163399467
cpu.1.time=453846564946
cpu.0.vtime=530053197220
cpu.1.vtime=446078894510
It's desired (for human consumption) to keep entries for given cpu
following each other.
This is missing any kind of description and documentation of the fields
both in the API files and in the virsh man page. That is a mandatory
requirement to add new fields to the bulk stats API.
Since I don't quite follow the meaning of the fields due to lack of
documentation I'm not going to review the code thoroughly.
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++-
src/util/vircgroup.c | 2 +-
src/util/vircgroup.h | 5 ++++
4 files changed, 77 insertions(+), 2 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)