Re: [libvirt] [PATCH v3 0/2] Fabric name must not be required for fc_host capability

On 01/16/2017 08:27 AM, Boris Fiuczynski wrote: > fabric_name is one of many fc_host attributes in Linux that is optional > and left to the low-level driver to decide if it is implemented. > > --- > Changes sinve v2: > - removed virReadFCHostOption method > - changed additional file check to be used permanently > > Changes since v1: > - split of minor correction in documenting comment > - added news entry... > - added new virReadFCHostOption method > - added check for file existence when optional is set > - rearranged fchost tests to fit the numbering > > --- > Boris Fiuczynski (2): > util: add file exists check in virReadFCHost > nodedev: Fabric name must not be required for fc_host capability > > docs/formatnode.html.in | 2 +- > docs/news.xml | 12 ++++++++++ > docs/schemas/nodedev.rng | 8 ++++--- > src/node_device/node_device_linux_sysfs.c | 9 +++---- > src/util/virutil.c | 5 +++- > tests/fchostdata/fc_host/host6/node_name | 1 + > tests/fchostdata/fc_host/host6/port_name | 1 + > tests/fchostdata/fc_host/host6/port_state | 1 + > tests/fchosttest.c | 40 ++++++++++++++++++++++++++++++- > 9 files changed, 67 insertions(+), 12 deletions(-) > create mode 100644 tests/fchostdata/fc_host/host6/node_name > create mode 100644 tests/fchostdata/fc_host/host6/port_name > create mode 100644 tests/fchostdata/fc_host/host6/port_state > ACK series, but I'll only push after 3.0.0 is out (and move the release note). John