Re: [libvirt] [PATCH] tests: work with older dbus
On 08/08/2013 04:03 PM, Daniel P. Berrange wrote:
On Thu, Aug 08, 2013 at 03:05:25PM -0600, Eric Blake wrote:
> On RHEL 5, with dbus 1.1.2, compilation failed with:
>
> virsystemdmock.c: In function 'dbus_connection_send_with_reply_and_block':
> virsystemdmock.c:68: warning: implicit declaration of function
'dbus_message_set_serial'
>
> Fix this by instead bypassing all attempts to use a dbus serial.
>
>
> I'm tempted to push this under the build-breaker rule, but it is
> still pending a review of this patch also for RHEL 5:
> https://www.redhat.com/archives/libvir-list/2013-August/msg00313.html
Still awaiting review on that one...
ACK, good idea for fixing this.
...but this one is now pushed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)