Re: [Libvir] [PATCH 1/2] KVM network stats
On Thu, Nov 15, 2007 at 03:53:00PM +0000, Richard W.M. Jones wrote:
Firstly there's a bug in how we parse /proc/net/dev. The format
of each
interface line turns out to be:
%6s:...
so in other words network interface names smaller than 6 characters are
right justified (padded on the left with spaces).
This isn't a problem for Xen because the shortest interface name (eg.
'vif1.0') is always 6 or more characters long. However it is a problem
for QEMU and KVM because we have interface names such as 'vnet0'.
In any case, the following patch fixes this bug.
Looks fine to me, bugfix, +1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/