Re: [libvirt] [PATCH] python: add virDomainGetCPUStats python binding API
On 03/14/2012 05:10 PM, Eric Blake wrote:
On 03/14/2012 03:02 AM, Daniel Veillard wrote:
> On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
>> On 03/14/2012 01:57 PM, Guannan Ren wrote:
>>> dom.cPUStats(True, 0)
>> I'd like getVcpuStats or cpuStats function naming.
> Based on existing conventions, it should be getVcpuStats() method,
getVcpuStats is wrong - if flags is 0, we are getting stats on the
physical cpu of the host, not the vcpu of the guest.
I think we want getCpuStats.
getCPUStats is occupied by virNodeGetCPUStates. Renaming it is not
good idea.
It probably impact on those calling python code.
I propose getDomCPUStates, what do you think about it?
Guannan Ren