Re: [PATCH v2 16/27] network: turn on auto-rollback for the rules added for virtual networks
On 4/23/24 6:53 AM, Daniel P. Berrangé wrote:
On Sun, Apr 21, 2024 at 10:53:24PM -0400, Laine Stump wrote:
> diff --git a/tests/networkxml2firewalltest.c b/tests/networkxml2firewalltest.c
> index 3a9f409e2a..e61787daec 100644
> --- a/tests/networkxml2firewalltest.c
> +++ b/tests/networkxml2firewalltest.c
> @@ -79,7 +79,14 @@ testCommandDryRun(const char *const*args G_GNUC_UNUSED,
> void *opaque G_GNUC_UNUSED)
> {
> *status = 0;
> - *output = g_strdup("");
> + /* if arg[1] is -ae then this is an nft command,
> + * and the caller requested to get the handle
> + * of the newly added object in stdout
> + */
> + if (STREQ_NULLABLE(args[1], "-ae"))
> + *output = g_strdup("# handle 5309");
> + else
> + *output = g_strdup("");
Belongs in the later nft tests patch
Ah, yep! Another byproduct of reordering patches (and
splitting/recombining/rewriting others).