Re: [PATCH 3/3] rpm: Configure firewall backends explicitly
On Tue, May 28, 2024 at 05:49:21PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 6fb223c74a..4381dbe30c 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1387,6 +1387,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y'
%{_specdir}/libvirt.spec)
%{?enable_werror} \
-Dexpensive_tests=enabled \
-Dinit_script=systemd \
+ -Dfirewall_backend_priority=nftables,iptables \
This change isn't right as it doesn't match earlier logic in the spec
which is version specific
%if 0%{?rhel} >= 10 || 0%{?fedora} >= 41
Requires: nftables
%else
Requires: iptables
%endif
ie, we should *not* be preferring nftables on existing RHEL and Fedora,
only future, otherwise users will get a functional behaviour change
on their existing distro.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|