Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

> Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU > properties that are preventing the CPU model from running in the > current host. > > Cc: David Hildenbrand <dahi(a)linux.vnet.ibm.com&gt; > Cc: Michael Mueller <mimu(a)linux.vnet.ibm.com&gt; > Cc: Christian Borntraeger <borntraeger(a)de.ibm.com&gt; > Cc: Cornelia Huck <cornelia.huck(a)de.ibm.com&gt; > Cc: Jiri Denemark <jdenemar(a)redhat.com&gt; > Cc: libvir-list(a)redhat.com > Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com&gt; > --- > qapi-schema.json | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 54634c4..450e6e7 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2948,11 +2948,19 @@ > # Virtual CPU definition. > # > # @name: the name of the CPU definition > +# @runnable: true if the CPU model is runnable using the current > +# machine and accelerator. Optional. Since 2.6. > +# @unavailable-features: List of properties that prevent the CPU > +# model from running in the current host, > +# if @runnable is false. Optional. > +# Since 2.6. Just FYI, on other architectures (e.g. s390x), other conditions (e.g. cpu generation) also define if a CPU model is runnable, so the pure availability of features does not mean that a cpu model is runnable. We could have runnable=false and unavailable-features being an empty list.