Re: [libvirt] [PATCH] virsh: Improve virsh manual for virsh memtune command

On 09/22/2011 04:14 AM, Peter Krempa wrote: > Commit 0a22f54 added --min-guarantee option for the memtune command. > This option is supported only by the ESX hypervisor. This patch adds a > statement about this fact, to prevent user confusion. > > This patch also adds explanation how to clear/set to unlimited the > memory tunables. (documments the -1 value). > --- > tools/virsh.pod | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/tools/virsh.pod b/tools/virsh.pod > index 88dee26..7f46ee4 100644 > --- a/tools/virsh.pod > +++ b/tools/virsh.pod > @@ -959,6 +959,7 @@ Allows you to display or set the domain memory > parameters. Without > flags, the current settings are displayed; with a flag, the > appropriate limit is adjusted if supported by the hypervisor. LXC and > QEMU/KVM support I<--hard-limit>, I<--soft-limit>, and > I<--swap-hard-limit>. > +I<--min-guarantee> is supported only by ESX hypervisor yet. s/ yet//. (The sentence makes better sense without that word, and we can edit the docs if we later add --min-guarantee support for qemu). ACK with that nit fixed.