Re: [libvirt] [PATCH 3/3] test-lib.sh: Update helper for VIR_TEST_EXPENSIVE and use it in virsh-all

On 08/01/2013 07:24 AM, Peter Krempa wrote: > When the test-lib for shell tests was introduced it did think of > expensive tests although this option was never used. More historically accurate: the shell script was lifted verbatim from GNU coreutils, back in the days when Jim Meyering was actively contributing here, where coreutils DOES have expensive tests. We have just never marked a test expensive in libvirt until now. But our test driver shell script diverged from coreutils long enough ago that I'm fine tweaking the script for our own needs instead of trying to resync from coreutils, so making further tweaks isn't going to make it harder to converge. > Update the code for > the new env variable name. > > Use this function in the virsh-all test that blindly runs all virsh > commands without any arguments and thus it's rather time consuming than s/rather/more/ > useful. Mark it as expensive to skip this test in normal cases. > --- > tests/test-lib.sh | 10 +++++----- > tests/virsh-all | 2 ++ > 2 files changed, 7 insertions(+), 5 deletions(-) >

That leaves just this part of your patch, once you rebase on top of my fixes. I agree with making this test marked expensive, and with doing it as a separate patch on top of the framework, so ACK to this portion once rebased on top of my patches.