Re: [libvirt] [PATCH 3/13 v2] virsh: Split cmds of domain group from virsh.c
On 2012年07月25日 21:34, Peter Krempa wrote:
On 07/24/12 11:29, Osier Yang wrote:
> Attach 3/13 after compression. Thank goodness, 134K is lower than 150K.
>
> Regards,
> Osier
Yep, but still hell of a patch to review. I verified that all aditions
match the removed parts of code (but not otherwise) by optical means.
I'd split out some of the function in a special helper file (specialy
functions that start vsh*)
Yeah, I believe there are still many optimization space left.
but that could be later patches. For the special helper file,
perhaps in virsh.c is fine if it's small enough.
Regards,
Osier