On Mon, Sep 10, 2012 at 11:36:27AM +0100, Daniel P. Berrange wrote:
Considering how the code worked in the past, the comment was
actually
correct originally. We never invoked virNetClientIOHandleOutput from
the event handler callback - we only used the callback for dealing
with *incoming* I/O. Only when we recently changed the keepalive
code to make use of the event handler callbacks did we now start
doing outgoiing I/O. This invalidated the comment & return code we
used here, but introducing the scenario described above.
ACK
Thanks for the additional explanation, pushed.
Christophe