Re: [libvirt] [PATCH 5/6] Change 'int isTempChain' to bool in nwfilter
On Tue, Mar 18, 2014 at 09:21:14AM -0600, Eric Blake wrote:
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
> The 'int isTempChain' parameter to various nwfilter methods
> only takes two values so should be a bool type.
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> src/nwfilter/nwfilter_ebiptables_driver.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
This touches a lot of the same lines as 1/6 when you changed incoming to
bool. Should you squash the two patches to minimize the churn?
I just found it easier to review the change when it was only doing
one variable at a time, so I think its nicer to keep them separate
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|