Re: [libvirt] [PATCH] build: avoid non-portable byte-swapping

On 09/18/12 21:55, Eric Blake wrote: > Commit 0fc89098 used functions only available on glibc, completely > botched 32-bit environments, and risked SIGBUS due to unaligned > memory access on platforms that aren't as forgiving as x86_64. > > * bootstrap.conf (gnulib_modules): Import ffsl. > * src/util/bitmap.c (includes): Use <strings.h> for ffsl. > (virBitmapNewData, virBitmapToData): Avoid 64-bit assumptions and > non-portable functions. > --- > > I wish I could push this under the build-breaker rule, but it is > not quite trivial enough. Indeed. Bit magic never was trivial :).

ACK. If there isn't a bug in my "brain simulation unit" then this should work as intended.