Re: [libvirt PATCH v3 1/2] cpu_map: Add script to sync from QEMU i386 cpu models
On Wed, Nov 04, 2020 at 11:53:50 +0100, Tim Wiederhake wrote:
This script is intended to help in synchronizing i386 QEMU cpu model
definitions with libvirt.
As the QEMU cpu model definitions are post processed by QEMU and not
meant to be consumed by third parties directly, parsing this
information is imperfect. Additionally, the libvirt models contain
information that cannot be generated from the QEMU data, preventing
fully automated usage. The output should nevertheless be helpful for
a human in determining potentially interesting changes.
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
src/cpu_map/sync_qemu_i386.py | 369 ++++++++++++++++++++++++++++++++++
1 file changed, 369 insertions(+)
create mode 100755 src/cpu_map/sync_qemu_i386.py
Thanks, this version pases flake8 and works with python older than 3.9.
The script does a great job at checking CPU model inconsistencies or
introducing new model to libvirt.
Would it be possible to extend this script a bit to also to detect
features supported by QEMU and not present in
src/cpu_map/x86_features.xml (or add a second script for this task)?
Anyway, this version is ready to be pushed...
Reviewed-by: Jiri Denemark <jdenemar(a)redhat.com>