On Tue, Jan 17, 2017 at 10:22:10AM -0500, Jason J. Herne wrote:
On 01/16/2017 08:01 PM, Eduardo Habkost wrote:
> This is a follow-up to the series that implements
> query-cpu-model-expansion. Before including the test script, the
> series has some fixes to allow the results of
> query-cpu-model-expansion to be used in the QEMU command-line.
>
> The script probably will work on s390x too, but I couldn't test
> it yet.
>
Eduardo,
This test seems to mostly work on s390. The only issue I ran into is
querying host model using tcg only. s390 requires kvm to query the host
model. Perhaps we could just skip the tcg host test case on s390?
We could still try to test "host", but add it to a greylist where
errors returned by query-cpu-model-expansion can be non-fatal.
query-cpu-model-expansion model="host" can also fail with KVM if
the host doesn't support CPU models.
hernejj: ['/usr/local/bin/qemu-system-s390x', '-chardev',
'socket,id=mon,path=/var/tmp/qom-fetch-monitor.sock', '-mon',
'chardev=mon,mode=control', '-display', 'none', '-vga',
'none', '-qtest',
'unix:path=/var/tmp/qom-fetch-qtest.sock', '-qtest-log',
'/dev/null',
'-machine', 'accel=qtest', '-machine', 'accel=tcg',
'-S', '-cpu', 'host']
qemu-system-s390x: CPU definition requires KVM
E
======================================================================
ERROR: testTCGModels (__main__.CPUModelTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./query-cpu-model-test.py", line 380, in testTCGModels
self.checkAllCPUModels()
File "./query-cpu-model-test.py", line 375, in checkAllCPUModels
self.checkOneCPUModel(m)
File "./query-cpu-model-test.py", line 304, in checkOneCPUModel
self.checkExpansions(model, msg)
File "./query-cpu-model-test.py", line 221, in checkExpansions
'%s.static' % (msg))
File "./query-cpu-model-test.py", line 177, in checkOneExpansion
type=type, model=model['model'])
File "./../scripts/qemu.py", line 185, in command
raise Exception(reply["error"]["desc"])
Exception: The CPU definition 'host' requires KVM
----------------------------------------------------------------------
Ran 2 tests in 74.622s
--
-- Jason J. Herne (jjherne(a)linux.vnet.ibm.com)
--
Eduardo