Re: [libvirt] [PATCH 4/7] docs: process code blocks similar to markdown
On 01/22/2013 07:31 AM, Claudio Bley wrote:
Wrap pre-formatted example code in <code> elements. This works
similar to markdown code blocks.
Every line indented with at least 2 spaces is considered a code
block and gets wrapped in <pre> and <code> tags.
Signed-off-by: Claudio Bley <cbley(a)av-test.de>
---
docs/newapi.xsl | 89 +++++++++++++++++++++++++++++++++++++++++--------------
1 file changed, 67 insertions(+), 22 deletions(-)
I tried to see a page where this would make a difference; but
http://libvirt.org/html/libvirt-libvirt.html#virDomainGetMemoryParameters didn't
pick up any new formatting in my local version. For these patches,
calling out an anchor where the differences can be visually inspected
will make review much easier. Or is this a case where we also need to
touch up src/libvirt.c to actually provide the indentation that this xsl
patch is looking for? At any rate, I don't feel comfortable acking
until I can see the improvement (since I am not fluent in xsl); but if
the idea works, it makes total sense (as the current code chunks on the
web page render quite horribly).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)