Re: [libvirt] [jenkins-ci PATCH v2 1/6] jobs: Introduce autotools-website-job
On Tue, 2018-04-17 at 10:52 +0100, Daniel P. Berrangé wrote:
On Thu, Apr 12, 2018 at 05:59:26PM +0200, Andrea Bolognani wrote:
> diff --git a/jobs/autotools.yaml b/jobs/autotools.yaml
> index 0c164d3..9b26bc3 100644
> --- a/jobs/autotools.yaml
> +++ b/jobs/autotools.yaml
> @@ -257,3 +257,70 @@
> recipients: '{obj:spam}'
> notify-every-unstable-build: true
> send-to-individuals: false
> +
> +- job-template:
> + id: autotools-website-job
> + name: '{name}-{branch}-website'
> + project-type: matrix
> + description: '{title} Website'
> + autogen_args: ''
> + workspace: '{name}-{branch}-website'
[...]
IMHO adding this big single-use only job template is not desirable
or needed. The point of templates is to provide reuse across many
projects. Just define the libvirt-website job using the generic-build-job
template instead.
Good point.
The only problem I can see with that approach is that such a job
would share the same workspace as the regular libvirt builds, which
is something that we don't want in general; however, given that the
website job is only going to be running on CentOS 6 and vice versa,
we can safely go ahead with it.
--
Andrea Bolognani / Red Hat / Virtualization