Re: [Libvir] [PATCH] Three cleanup patches
Daniel Veillard wrote:
On Thu, May 10, 2007 at 05:24:00PM +0100, Richard W.M. Jones wrote:
> * Add some extra generated files to .cvsignore
>
> * Remove an unused header in qemud/uuid.c
>
> * Log an error if xenHypervisorOpen fails because xenHypervisorInit has
> failed.
just wondering about the last one, would that add a message if trying
as non-root ?
Yes it does, so that third patch is wrong. In fact xenHypervisorInit
already produces errors for all paths except the one where opening the
HV connection fails.
OK to commit the first two?
Rich.
--
Emerging Technologies, Red Hat http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421
Attachments:
- smime.p7s (application/x-pkcs7-signature — 3.2 KB)