Re: [libvirt] [PATCH 2/2] Revert "Prevent more compiler optimization of mockable functions"

On Wed, Jul 12, 2017 at 01:56:47PM +0200, Martin Kletzander wrote: > Also, having the weak alias we can drop all the mocks and the problems > with them and just redefine the functions we would like to mock in the > tests (see tests/virfilewrapper.c), it would work on win32, it would > not compile if we would forgot to make the function as an alias (so no > need to check that in the syntax-check) and maybe provide other benefits > that I can't think of right now. Empirically I'm not seeing any compiler warnings if i take this approach and don't mark the function as an alias.