Re: [PATCHv3 4/4] netlink: Introduce a helper function to simplify netlink functions
On 1/13/21 12:51 PM, Michal Privoznik wrote:
On 1/12/21 2:29 AM, Shi Lei wrote:
> On 2021-01-11 at 19:26, Michal Privoznik wrote:
>> On 1/11/21 3:23 AM, Shi Lei wrote:
>>> Extract common code as helper function virNetlinkTalk, then simplify
>>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
>>>
>>> Signed-off-by: Shi Lei <shi_lei(a)massclouds.com>
>>> ---
>>> src/util/virnetlink.c | 232
>>> ++++++++++++++++++------------------------
>>> src/util/virnetlink.h | 4 +-
>>> 2 files changed, 101 insertions(+), 135 deletions(-)
>>>
>>
>> Anyway, I can fix that before pushing, so that you don't have to send
>> another version. Do you agree if this is squashed in?
>>
>
> I agree. Thanks!
>
Okay, we are currently in feature freeze preparing for release. I will
push it afterwards.
Pushed now.
Michal