Re: [libvirt] [PATCH 0/3] libxl: Add a test suite for libxl_domain_config generator

On Sun, Feb 26, 2017 at 07:02:24PM -0700, Jim Fehlig wrote: Few more months have passed... FWIW, I've tested it with Xen 4.6. The patch needs very minor update: - s/VIRT_TEST_MAIN_PRELOAD/VIR_TEST_MAIN_PRELOAD/ - add xencaps argument to libxlBuildDomainConfig call After that, it works! When I made some test to fail, reported error is not so helpful ("libvirt: Xen Light Driver error : internal error: Expected and actual libxl_domain_config objects do not compare"), but it do catch failures. Then, if I change strcmp to virTestCompareToString, the output is much more helpful. I'd really love to have it merged, mostly because I want to add more tests using this framework (see "Add setting CPU features (CPUID) with libxenlight driver" thread). Is there anything I can do to make it happen? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?