Re: [libvirt] [PATCH 1/6] Move file format enum to libvirt_util
On Tue, Sep 29, 2009 at 11:27:18AM +0200, Pritesh Kothari wrote:
> +enum virStorageFileFormat {
> + VIR_STORAGE_FILE_RAW = 0,
> + VIR_STORAGE_FILE_DIR,
> + VIR_STORAGE_FILE_BOCHS,
> + VIR_STORAGE_FILE_CLOOP,
> + VIR_STORAGE_FILE_COW,
> + VIR_STORAGE_FILE_DMG,
> + VIR_STORAGE_FILE_ISO,
> + VIR_STORAGE_FILE_QCOW,
> + VIR_STORAGE_FILE_QCOW2,
> + VIR_STORAGE_FILE_VMDK,
> + VIR_STORAGE_FILE_VPC,
> + VIR_STORAGE_FILE_LAST,
> +};
Any chance we could add
VIR_STORAGE_FILE_VDI (VirtualBox)
and VIR_STORAGE_FILE_HDD (Parallels)
here as well?
Of course - patches to add more formats are welcome. The formats we
have there so far are just the ones I was able to figure out from the
qemu-img source. At the minimum level you just need to figure out the
magic bytes to identify the format, and the offset into the file
where the logical capacity is stored.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|