Re: [libvirt] [PATCH] xenapi: Improve error reporting in xenapiOpen once again

On 07/21/2011 07:17 AM, Matthias Bolte wrote: > > privP->session->error_description is a list and in order to get the > complete error message all parts of the list should be concatenated. > xenapiSessionErrorHandler does this when its third parameter is NULL. > The current code discards all but the first part of the error message > resulting in a potentially incomplete error message. > > This partly reverts 006be75ee214f9b4, that tried to avoid reporting > a (null) in the error message. The actual problem is more general in > returnErrorFromSession that might return NULL if there is no error. > > Make sure that returnErrorFromSession return non-NULL always. Also > don't skip the last error message part. > --- >  src/xenapi/xenapi_driver.c |    5 +---- >  src/xenapi/xenapi_utils.c  |    4 +++- >  2 files changed, 4 insertions(+), 5 deletions(-) ACK.