Re: [libvirt] [PATCH 2/6] tests: qemuxml2xml: Add basic DO_TEST_CAPS impl
On Sun, 2019-01-13 at 18:12 -0500, Cole Robinson wrote:
[...]
+# define DO_TEST_CAPS(name, arch, ver) \
This is called DO_TEST_CAPS_ARCH_VER() in xml2argv, and we shouldn't
deviate from that unless we have a very compelling reason to do so.
Ideally, you'd implement DO_TEST_CAPS_LATEST() instead, by lifting
all common bits from xml2argv and moving them into testutilsqemu,
but I understand if you don't want to spend your time doing that.
+ do { \
+ if (!(qemuCaps = qemuTestParseCapabilitiesArch(virArchFromString(arch), \
+ TEST_CAPS_PATH ver "."
arch ".xml"))) { \
+ printf("bad\n"); \
Bad leftover code, bad! :P
Looks reasonable otherwise, at least from a quick look.
--
Andrea Bolognani / Red Hat / Virtualization