Re: [libvirt] [PATCHv2 8/9] phyp: avoid memory leaks in command values

2011/4/14 Eric Blake <eblake(a)redhat.com&gt;: > * src/phyp/phyp_driver.c (phypExecBuffer): New function. Use it > throughout file for less code, and for plugging a few leaks. > --- > > Amazing how much copy-and-paste code this consolidated. > > " -p %s -o a -s %d -d 0 -a \"adapter_type=server\"", > vios_name, slot); > - if (virBufferError(&buf)) { > - virBufferFreeAndReset(&buf); > - virReportOOMError(); > - goto cleanup; > - } > - > - VIR_FREE(cmd); > - VIR_FREE(ret); Why are you killing the VIR_FREE(ret) here, in the hunk before you left it in. It's necessary here too.

ACK, with that VIR_FREEs left in.